A colorful self-made billionaire, Mr. Benson was alternately revered and reviled in New Orleans, where he reigned for four decades.